Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: cleanup unused code #16421

Merged
merged 1 commit into from Jan 2, 2024
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jan 2, 2024

Most of this wasn't used since the removal of default_formula from Requirements.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 734123f into Homebrew:master Jan 2, 2024
24 checks passed
@Bo98 Bo98 deleted the dependency-cleanup branch January 2, 2024 18:19
@ernie
Copy link

ernie commented Jan 2, 2024

@MikeMcQuaid FWIW, it looks like this breaks neovim HEAD install, failing with:

  NoMethodError: undefined method `modify_build_environment' for #<Dependency: "lpeg" []>

@timsutton
Copy link
Sponsor Member

^ seeing the same on a few other formula updates I have been testing: freerdp (cmake) and minio (go) for example

@Bo98
Copy link
Member Author

Bo98 commented Jan 2, 2024

Sorry, this is already fixed and I will look into improving where CI missed this for the future.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants