Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix bad modify_build_environment call #16422

Merged
merged 1 commit into from
Jan 2, 2024
Merged

build: fix bad modify_build_environment call #16422

merged 1 commit into from
Jan 2, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jan 2, 2024

Forgot to git add this.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Jan 2, 2024
@Bo98 Bo98 enabled auto-merge January 2, 2024 18:33
@Bo98 Bo98 merged commit a782847 into Homebrew:master Jan 2, 2024
23 checks passed
@Bo98 Bo98 deleted the build-fix branch January 2, 2024 18:59
@MikeMcQuaid
Copy link
Member

Thanks for quick fix @Bo98!

The default formula tests should have definitely caught this; they must be broken and not actually testing the contents of these PRs somehow.

I saw this at least one other time and wrote it off as me misunderstanding but this confirms it.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 2, 2024
Closed
@MikeMcQuaid
Copy link
Member

Opened #16423 to reproduce this.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bo98 @MikeMcQuaid @BrewTestBot @p-linnane