cmd/audit: fix type error in cask livecheck url audit #16443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This got updated recently in 42a42c9 to split out the livecheck audits and as a result of that the type signature for the #validate_url_for_https_availablity method got updated.
This did not account for the possibility that the livecheck url was nil. I've added a nil check here since it makes no sense to try and validate a nil url and we have nil checks for the other two http availability audits already. Plus, the livecheck blocks are audited thoroughly already for syntax.
This should fix the audit error mentioned in #16438 (comment).
CC: @reitermarkus @bevanjkay