Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ~/Library/Containers to the list of Layout/LineLength exclusions #16512

Merged
merged 1 commit into from Jan 20, 2024
Merged

Add ~/Library/Containers to the list of Layout/LineLength exclusions #16512

merged 1 commit into from Jan 20, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jan 20, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

issyl0 added a commit to issyl0/homebrew-cask that referenced this pull request Jan 20, 2024
@issyl0
webviewscreensaver: Remove line break & alphabetize correctly
69d2164 
- This needs Homebrew/brew#16512 to be merged
  to pass RuboCop's `Layout/LineLength` cop without the line break.
issyl0 added a commit to issyl0/homebrew-cask that referenced this pull request Jan 20, 2024
@issyl0
aerial: Remove line break & alphabetize correctly
5be932d 
- This needs Homebrew/brew#16512 to be merged
  to pass RuboCop's `Layout/LineLength` cop.
issyl0 added a commit to issyl0/homebrew-cask that referenced this pull request Jan 20, 2024
@issyl0
after-dark-classic: Remove line break & alphabetize correctly
dd98a38 
- This needs Homebrew/brew#16512 to be merged to pass RuboCop's `Layout/LineLength` cop.
@issyl0
Copy link
Member Author

issyl0 commented Jan 20, 2024

The docs linter is fixed in #16513.

@issyl0
Copy link
Member Author

issyl0 commented Jan 20, 2024

Rebased to get the BuildPulse link fixes from #16513.

@issyl0 issyl0 enabled auto-merge January 20, 2024 19:36
@issyl0 issyl0 merged commit 9b4427d into Homebrew:master Jan 20, 2024
24 checks passed
@issyl0 issyl0 deleted the another-cask-library-path branch January 20, 2024 21:05
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apainintheneck apainintheneck apainintheneck approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@issyl0 @apainintheneck