New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-cmd/bump: Point out if formulae should be kept in sync with others #16515
dev-cmd/bump: Point out if formulae should be kept in sync with others #16515
Conversation
- This will give some information to users of `brew bump` that they should keep the version of the formula in sync with other formulae. - A future enhancement is actually making the bumping of the "related" formulae automatic with `--open-pr`. But for now, telling people so that they don't have to wait until `brew audit` fails either locally or in CI at a later stage is a good start.
I like the sound of consolidating the duplicated-ish code that's in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks @issyl0!
@issyl0 Any thoughts on just jumping straight to the automatic step? Not saying you should do that instead of this PR or that it should block but just interested in your thought process here.
I think it could live in |
I didn't have brain power to figure out how to do the automatic step when I first looked at this, but I thought that this step was a good middle ground for telling users "watch out there's more work here" that's usually hidden in the JSON file. |
Yeh, I'm fine with merging this as an in-between step. My thinking is that something a I guess I ask because the code could be even simpler: something like:
|
- This way we can use them in the audit and in `bump`.
be25e20
to
1b5fa17
Compare
Looks good, thanks @issyl0! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew bump
refuses to bump linked formulae #16383.brew bump
that they should keep the version of the formula in sync with other formulae.--open-pr
. But for now, telling people so that they don't have to wait untilbrew audit
fails either locally or in CI at a later stage is a good start.