Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mechanize vendoring; add RBI defs #16558

Merged
merged 3 commits into from Feb 1, 2024
Merged

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Jan 31, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Relates to #16557

Adds an RBI to replace the hidden definitions for our use of mechanize.

I also noticed that we were keeping older versions of mechanize, so I updated that part of vendor-gems.

@dduugg dduugg force-pushed the mechanize-fixes branch 2 times, most recently from f3c9030 to 799bb6b Compare January 31, 2024 17:41
@Bo98 Bo98 merged commit f5068ab into Homebrew:master Feb 1, 2024
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @dduugg!

@dduugg dduugg deleted the mechanize-fixes branch February 8, 2024 17:34
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants