New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fail if superfluous packages are excluded #16603
fix: fail if superfluous packages are excluded #16603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a bit more context for what's happening here? What's a superfluous package and why is excluding one fatal?
So the thing I'm trying to fix is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for elaborating! Have put your explanation into the PR body so it'll be in a merge commit. One suggestion and then, when CI fixed, can approve and merge 👍🏻
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Fixes issue where:
six
formula so you add it to the exclude listsix
since currently we have no way to know if the excludes list has superfluous entries.