Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Handle tap migrations in CaskLoader." #16608

Merged
merged 1 commit into from Feb 6, 2024
Merged

Revert "Handle tap migrations in CaskLoader." #16608

merged 1 commit into from Feb 6, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Feb 6, 2024 •
edited

Reverts #16596 - PR seems to have broken some third-party taps

Closes #16607

@michaelmior michaelmior mentioned this pull request Feb 6, 2024
Closed
3 tasks
apainintheneck
apainintheneck approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @bevanjkay!

@apainintheneck apainintheneck merged commit 5799e85 into Homebrew:master Feb 6, 2024
24 checks passed
@apainintheneck
Copy link
Contributor

CC: @reitermarkus

reitermarkus added a commit to reitermarkus/brew that referenced this pull request Feb 6, 2024
@reitermarkus
Revert "Merge pull request Homebrew#16608 from bevanjkay/revert-16596…
feb818b 
…-cask-rename-migrations"

This reverts commit 5799e85, reversing
changes made to 6775171.
reitermarkus added a commit to reitermarkus/brew that referenced this pull request Feb 7, 2024
@reitermarkus
Revert "Merge pull request Homebrew#16608 from bevanjkay/revert-16596…
e5a6f76 
…-cask-rename-migrations"

This reverts commit 5799e85, reversing
changes made to 6775171.
@reitermarkus reitermarkus mentioned this pull request Feb 7, 2024
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apainintheneck apainintheneck apainintheneck approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brew search returns "invalid tap name"
2 participants
@bevanjkay @apainintheneck