Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require "branch: main" for resources with revisions set #16626

Merged
merged 1 commit into from Feb 9, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Feb 8, 2024

Just like when a tag is set, when a revision is set for a resource it shouldn't also specify that it comes from the main branch.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Just like when a tag is set, when a revision is set for a resource it shouldn't _also_ specify that it comes from the main branch.
Copy link
Member

@reitermarkus reitermarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@reitermarkus reitermarkus merged commit 14763c9 into Homebrew:master Feb 9, 2024
24 checks passed
@nex3 nex3 deleted the patch-1 branch February 9, 2024 23:14
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants