Include all test paths in RSpec cops #16642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
force-pushed
the
rubocop-rspec-paths
branch
from
7e66f4c
to
e98d352
Compare
Comment on lines
298
to
301
| let(:path_with_tilde) { Pathname.new("#{dir}/path_with_tilde") } | ||
| let(:glob_path1) { Pathname.new("#{dir}/glob_path1") } | ||
| let(:glob_path2) { Pathname.new("#{dir}/glob_path2") } | ||
| let(:paths) { [absolute_path, path_with_tilde, glob_path1, glob_path2] } | ||
| let(:glob_path) { Pathname.new("#{dir}/glob_path") } | ||
| let(:glob_path_) { Pathname.new("#{dir}/glob_path_") } | ||
| let(:paths) { [absolute_path, path_with_tilde, glob_path, glob_path_] } |
There was a problem hiding this comment.
This one doesn't make that much sense to me.
There was a problem hiding this comment.
Open to alternatives, just trying to obey the letter and not the spirit of the cop. 😈
There was a problem hiding this comment.
Open to alternatives, just trying to obey the letter and not the spirit of the cop. 😈
🤣
glob_path_alt?
That's a bit better. I'm fine with that.
dduugg
force-pushed
the
rubocop-rspec-paths
branch
from
e98d352
to
12d32cc
Compare
apainintheneck
approved these changes
Feb 12, 2024
MikeMcQuaid
approved these changes
Feb 12, 2024
I think that'd be nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Per docs:
(Possibly, we want to follow convention and rename the
testdir tospec, but we'd still have to apply the fixes here)