New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tap migrations with renames. #16648
Allow tap migrations with renames. #16648
Conversation
e634627
to
eaf7b38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense, thanks! Can you supply a small example of what this PR enables in terms of migrations and whether it's for formula/casks/both?
It enables this in {
"vlc-beta": "homebrew/cask/vlc@beta"
} We'll need it for migrating |
Very nice 👍🏻 👏🏻 |
Does this need extra migration code in update-report etc or is that covered? |
It should work with the existing code based on renames, since this basically only extends the list of renames. |
I haven't checked if we need to update the |
iirc we do for JSON installs but not Ruby installs |
Yeah, so we don't have it for |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This allows specifying full names in
tap_migrations.json
to migrate with a different name.Also fix the old/new name in the warning messages.