Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update.sh: parse GitHub API token from repository URL #16649

Merged
merged 16 commits into from Feb 13, 2024

Conversation

sazriel26
Copy link
Contributor

@sazriel26 sazriel26 commented Feb 13, 2024

When a private repository has a GitHub API token embedded in the Git URL: read it and use it to authenticate to the GitHub API when checking if there are any updates.

@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review February 13, 2024 08:42
@MikeMcQuaid MikeMcQuaid changed the title Parse git token - Continuation of #16289 update.sh: parse GitHub API token from repository URL Feb 13, 2024
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @sazriel26!

@MikeMcQuaid MikeMcQuaid merged commit 21566fc into Homebrew:master Feb 13, 2024
24 checks passed
@sazriel26 sazriel26 deleted the parse-git-token branch February 13, 2024 11:02
@sazriel26
Copy link
Contributor Author

Thank a lot to everybody, much appreciated support during this Pull Request 🙏

And of course, being able to see it in real (script brew.log brew update -d) was very nice too 🪄

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants