Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cask migration warnings. #16654

Merged
merged 4 commits into from Feb 14, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 13, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Readd a separate loader for the default tap to avoid showing a warning when a cask was migrated to it when trying to load a cask using the short token.

Fixes #16653.

@reitermarkus reitermarkus force-pushed the fix-cask-rename-warning branch 2 times, most recently from 763c6df to 536ecf3 Compare February 13, 2024 20:26
@reitermarkus reitermarkus changed the title Fix cask migration warning. Fix cask migration warnings. Feb 13, 2024
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice idea to add tests for to the formula loader too.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 24c8c0e into Homebrew:master Feb 14, 2024
24 checks passed
@reitermarkus reitermarkus deleted the fix-cask-rename-warning branch February 14, 2024 13:10
@Bo98 Bo98 mentioned this pull request Feb 14, 2024
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Cask homebrew/core/X was renamed to X.
3 participants