Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_creator: Remove unused GitHub property #16676

Merged
merged 1 commit into from Feb 16, 2024

Conversation

abitrolly
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #16675.

@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review February 16, 2024 08:43
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @abitrolly!

@MikeMcQuaid MikeMcQuaid merged commit 645cf35 into Homebrew:master Feb 16, 2024
24 checks passed
@abitrolly
Copy link
Contributor Author

@MikeMcQuaid it was not ready yet. :D I think I opened it as a draft PR, or at least intended to do so.

What .null? check does here? I can't find that Ruby has that syntax.

if @version.nil? || @version.null?

@abitrolly abitrolly changed the title formula_creator: Fix GitHub parsing when name doesn't match URL formula_creator: Remove unused GitHub property Feb 16, 2024
@MikeMcQuaid
Copy link
Member

@MikeMcQuaid it was not ready yet. :D I think I opened it as a draft PR, or at least intended to do so.

Yup, sorry for overly quick merge.

What .null? check does here? I can't find that Ruby has that syntax.

This is a Version object inside Homebrew itself with a null? method.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew create fails to fetch description if name doesn't match URL
2 participants