Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky Formulary test. #16680

Merged
merged 2 commits into from Feb 16, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 16, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The CaskLoader and Formulary tests use the same tap migrations, but in opposite directions. I assume there is a small possibility that both migrations exist at the same time, resulting in an infinite loop between the two taps.

I added two tests to reproduce the flaky test. Will have a look later at how to best fix this. Simplest solution for now is to not use the same formula/cask name, but that doesn't really scale.

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Feb 16, 2024
@reitermarkus reitermarkus merged commit a6d539c into Homebrew:master Feb 16, 2024
25 checks passed
@reitermarkus reitermarkus deleted the loader-infinite-recursion branch February 16, 2024 09:58
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants