Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API::tap_from_source_download for relative paths. #16690

Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 16, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Extracted from #16689.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what would be passing relative paths here? Formulary should be called with an absolute path.

But OK code wise

@reitermarkus
Copy link
Member Author

Not entirely sure what would be passing relative paths here?

Nothing yet, but the fix in #16689 uses this method to check if a path is a source download path, so it should work with any path and never raise an error.

@reitermarkus reitermarkus merged commit 7eafefb into Homebrew:master Feb 17, 2024
24 checks passed
@reitermarkus reitermarkus deleted the api-tap_from_source_download branch February 17, 2024 03:47
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants