Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tapioca args to config; exclude unnecessary gems #16691

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Move tapioca args to config; exclude unnecessary gems #16691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d05e9c5
Add tapioca config
dduugg Feb 16, 2024
c452aaf
Exclude unnecessary gems from tapioca
dduugg Feb 16, 2024
c7142b5
brew tc --update-all
dduugg Feb 16, 2024
89b5914
Add test that are exclusions are active dependencies
dduugg Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions Library/Homebrew/dev-cmd/typecheck.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,8 @@ def self.typecheck
HOMEBREW_LIBRARY_PATH.cd do
if update
safe_system "bundle", "exec", "tapioca", "dsl"
# RBI files already provided by Sorbet:
excluded_gems = [
"json",
"msgpack",
]
tapioca_args = ["--exclude", *excluded_gems, "--pre", "sorbet/tapioca/prerequire.rb"]
tapioca_args << "--all" if args.update_all?
# Prefer adding args here: Library/Homebrew/sorbet/tapioca/config.yml
tapioca_args = args.update_all? ? ["--all"] : []

ohai "Updating homegrown RBI files..."
safe_system "bundle", "exec", "ruby", "sorbet/custom_generators/tty.rb"
Expand Down
36 changes: 0 additions & 36 deletions Library/Homebrew/sorbet/rbi/gems/byebug@11.1.3.rbi
View file
Open in desktop

This file was deleted.