Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass warn in FromNameLoader. #16729

Merged
merged 1 commit into from Feb 23, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 22, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Feb 22, 2024
@reitermarkus reitermarkus merged commit 96f861e into Homebrew:master Feb 23, 2024
25 checks passed
@reitermarkus reitermarkus deleted the warn-from-name-loader branch February 23, 2024 00:27
@MikeMcQuaid
Copy link
Member

@reitermarkus Can you provide some context on why this is needed? Thanks.

@reitermarkus
Copy link
Member Author

Without it, no rename warning will ever be shown when using this loader.

@MikeMcQuaid
Copy link
Member

@reitermarkus Ok, thanks. In future PRs: can you put that context in the body (particularly when using critical to self-merge)? Thanks!

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants