Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/pypi: default to formula version when using package_name #16771

Merged
merged 1 commit into from
Mar 6, 2024
Merged

utils/pypi: default to formula version when using package_name #16771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion Library/Homebrew/utils/pypi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@
end

main_package = if package_name.present?
Package.new(package_name, python_name: python_name)
package_string = package_name
package_string += "==#{formula.version}" if version.blank? && formula.version.present?
Package.new(package_string, python_name: python_name)

Check warning on line 244 in Library/Homebrew/utils/pypi.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/utils/pypi.rb#L244 

Added line #L244 was not covered by tests
elsif package_name == ""
nil
else
Expand Down