Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula: remove setting up home for python 2.7 #16888

Merged
merged 1 commit into from Mar 14, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 14, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I don't think we need this in homebrew/core where we removed Python 2 usage and none of our runners have Python 2. We even have some workarounds to delete this path in a couple formula tests (e.g. git-annex).

May need some input if there is any use for external taps (in which case I can keep around in unless @tap.core_tap?) or source-builds (in which case maybe some other restriction)

Signed-off-by: Michael Cho <michael@michaelcho.dev>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, makes sense to me, thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit a7d7748 into Homebrew:master Mar 14, 2024
26 checks passed
@cho-m cho-m deleted the formula-no-python2.7-dir branch March 14, 2024 11:41
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants