Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/update-reset: use stable tag. #16891

Merged
merged 1 commit into from Mar 14, 2024
Merged

cmd/update-reset: use stable tag. #16891

merged 1 commit into from Mar 14, 2024

Conversation

MikeMcQuaid
Copy link
Member

Currently we always reset Homebrew/brew onto the latest master. Instead, let's correctly use the latest tag when appropriate.

See also Homebrew/install#839

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update.sh technically does refs/tags/${latest_git_tag} to avoid any name clash, though not sure if that matters much.

@MikeMcQuaid
Copy link
Member Author

@Bo98 unlike installer: I think this script needs to be rock-solid regardless of local state so: pushing a fix.

Currently we always reset Homebrew/brew onto the latest `master`.
Instead, let's correctly use the latest tag when appropriate.
@MikeMcQuaid MikeMcQuaid merged commit 5012e2d into master Mar 14, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the update_reset_tag branch March 14, 2024 16:51
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants