rubocops/service_spec: update test for name and require root #16929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… root This was added in recently and this just updates the test to reflect the expected behavior for the cop.
| @@ -19,13 +19,14 @@ class Foo < Formula | |||
| RUBY | |||
| end | |||
|
|
|||
| it "reports no offenses when a service block only includes custom names" do | |||
| it "reports no offenses when a service block includes custom names and requires root" do | |||
There was a problem hiding this comment.
Is there a connection between these two things? If not, these should be two separate tests.
There was a problem hiding this comment.
I guess require_root alone should still report an offense, and name alone shouldn't.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This was added in recently and this just updates the test to reflect the expected behavior for the cop.
#16914