Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the EnvConfig RBI generator to a Tapioca compiler #16980

Merged
merged 2 commits into from Mar 30, 2024
Merged

Convert the EnvConfig RBI generator to a Tapioca compiler #16980

merged 2 commits into from Mar 30, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0 issyl0 requested a review from dduugg March 30, 2024 18:39
@issyl0 issyl0 marked this pull request as ready for review March 30, 2024 18:39
dduugg
dduugg approved these changes Mar 30, 2024
View reviewed changes
Copy link
Sponsor Member

@dduugg dduugg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a tiny suggestion

Library/Homebrew/sorbet/tapioca/compilers/env_config.rb Outdated Show resolved Hide resolved
@issyl0 @dduugg
Apply suggestions from code review
75db3b8 
Co-authored-by: Douglas Eichelberger <697964+dduugg@users.noreply.github.com>
@issyl0 issyl0 merged commit 3f1ae21 into master Mar 30, 2024
26 checks passed
@issyl0 issyl0 deleted the tapioca-compiler-for-envconfig-rbi branch March 30, 2024 20:06
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0 and for review @dduugg!

@github-actions github-actions bot added the outdated PR was locked due to age label May 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dduugg dduugg dduugg approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@issyl0 @MikeMcQuaid @dduugg