New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV: deprecate old methods. #1701

Merged
merged 1 commit into from Dec 30, 2016

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Dec 19, 2016

These should have been deprecated long ago but we didn’t really have the necessary framework to do so.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

def x11
end
alias libpng x11

# we've seen some packages fail to build when warnings are disabled!
def enable_warnings

This comment has been minimized.

@nijikon

nijikon Dec 20, 2016

Contributor

Shouldn't this be removed as well?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Dec 20, 2016

Member

Technically a valid API in env :std. I guess there's an argument that we should remove any of these that aren't still used/needed in homebrew/core (e.g. ENV.libxml2 is because we use in in test do which uses env :std). Thoughts?

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:deprecate-std-superenv-stuff branch 2 times, most recently from f043cca to df64131 Dec 20, 2016

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:deprecate-std-superenv-stuff branch 3 times, most recently from 512ef82 to 54f087a Dec 29, 2016

Still a valid API

ENV: deprecate old methods.
These should have been deprecated long ago but we didn’t really have
the necessary framework to do so.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:deprecate-std-superenv-stuff branch from 54f087a to e50102d Dec 30, 2016

@MikeMcQuaid MikeMcQuaid merged commit b1e27d6 into Homebrew:master Dec 30, 2016

3 checks passed

codecov/patch 73.68% of diff hit (target 63.02%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +10.65% compared to c29a458
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:deprecate-std-superenv-stuff branch Dec 30, 2016

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.