Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV: deprecate old methods. #1701

Merged
merged 1 commit into from
Dec 30, 2016
Merged

ENV: deprecate old methods. #1701

merged 1 commit into from
Dec 30, 2016

Conversation

MikeMcQuaid
Copy link
Member

These should have been deprecated long ago but we didn’t really have the necessary framework to do so.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Dec 19, 2016
def x11
end
alias libpng x11

# we've seen some packages fail to build when warnings are disabled!
def enable_warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be removed as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically a valid API in env :std. I guess there's an argument that we should remove any of these that aren't still used/needed in homebrew/core (e.g. ENV.libxml2 is because we use in in test do which uses env :std). Thoughts?

These should have been deprecated long ago but we didn’t really have
the necessary framework to do so.
@MikeMcQuaid MikeMcQuaid merged commit b1e27d6 into Homebrew:master Dec 30, 2016
@MikeMcQuaid MikeMcQuaid deleted the deprecate-std-superenv-stuff branch December 30, 2016 20:43
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Dec 30, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants