cmd/log: various fixes. #17056
Merged
cmd/log: various fixes. #17056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't pass through `args:` when called with no arguments; these don'T need to be passed and end up breaking things instead. - Make `T.must` as early as possible. - Add a type signature to `git_log` to enable `typed: strict` and catch these sorts of bugs earlier next time. - `--follow` only works with a single file so check if the path is a file before adding it to the arguments.
ZhongRuoyu
approved these changes
Apr 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
args:when called with no arguments; these don'T need to be passed and end up breaking things instead.T.mustas early as possible.git_logto enabletyped: strictand catch these sorts of bugs earlier next time.--followonly works with a single file so check if the path is a file before adding it to the arguments.Fixes #17054