Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github: paginate artifact API result #17138

Merged
merged 2 commits into from Apr 23, 2024
Merged

utils/github: paginate artifact API result #17138

merged 2 commits into from Apr 23, 2024

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

There can be too many artifacts in a workflow run to fit in a single API response, so we need to paginate the result.

@ZhongRuoyu ZhongRuoyu added the bug Reproducible Homebrew/brew bug label Apr 23, 2024
There can be too many artifacts in a workflow run to fit in a single API
response, so we need to paginate the result.
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 04fc95b into master Apr 23, 2024
25 checks passed
@Bo98 Bo98 deleted the artifacts-pagination branch April 23, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reproducible Homebrew/brew bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants