utils/analytics: cleanup test-bot analytics. #17154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Apr 26, 2024
Library/Homebrew/utils/analytics.rb
Outdated
| step_command_short.split | ||
| .map { |arg| arg.sub(/=.*/, "=") } | ||
| .partition { |arg| !arg.start_with?("-") } | ||
| command = (command_and_package + options.sort).join(" ") |
There was a problem hiding this comment.
If we're going to do options.sort then we may also want to deal with --option foo flags (since we only currently handle --option=foo flags by stripping the foo).
There was a problem hiding this comment.
@carlocab If this is overkill: we could probably pull it all out. We don't use any long flags in brew test-bot like this now, even moreso after the filtering in Homebrew/homebrew-test-bot#1043
There was a problem hiding this comment.
Seems overkill TBH. Better to pull it out, especially since I think the earlier call to partition also means that the foo in --flag foo gets put in command_and_package, so not sure it really does what's needed
Sort options to ensure consistent ordering and improve readability. Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
MikeMcQuaid
force-pushed
the
cleanup_test_bot_analytics
branch
from
92ca38f
to
414e221
Compare
carlocab
approved these changes
Apr 26, 2024
|
@carlocab Whoops, auto-merge, follow-up incoming. |
MikeMcQuaid
added a commit
that referenced
this pull request
Apr 26, 2024
#17154 (comment) was ignored by auto-merge, whoops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort options to ensure consistent ordering and improve readability.