Optimise more command handling/speed #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in `brew.sh` split the `case` into those cases that take a single or no arguments and those that take multiple arguments or handle multiple commands. This considerably speeds up the `brew shellenv bash` case that wasn't being handled here before. - add `setup-ruby` to the list of commands that can be called quickly by `brew.sh` without additional setup. This speeds up the `brew setup-ruby` no-op case by ~10x. - add a parameter to `setup-ruby` to avoid running Bundler if the command doesn't need it. This makes many more cases for `brew setup-ruby` to be no-op cases. - Remove the (now) unused `HOMEBREW_RUBY3` check in `setup-ruby`. - Improve argument handling in `command_path.sh` to allow it to be used as a function in `setup-ruby.sh`. - Add a new RuboCop to check usage of `install_bundler_gems!` is only inside `dev-cmd` (or a few other acceptable places). - Use new `processed_source.file_path` API in `formula_cop.rb`
carlocab
approved these changes
Apr 30, 2024
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew.shsplit thecaseinto those cases that take a single or no arguments and those that take multiple arguments or handle multiple commands. This considerably speeds up thebrew shellenv bashcase that wasn't being handled here before.setup-rubyto the list of commands that can be called quickly bybrew.shwithout additional setup. This speeds up thebrew setup-rubyno-op case by ~10x.setup-rubyto avoid running Bundler if the command doesn't need it. This makes many more cases forbrew setup-rubyto be no-op cases.HOMEBREW_RUBY3check insetup-ruby.command_path.shto allow it to be used as a function insetup-ruby.sh.install_bundler_gems!is only insidedev-cmd(or a few other acceptable places) (follow-up from CallHomebrew.install_bundler_gems!more consistently. #17185 (comment))processed_source.file_pathAPI informula_cop.rb