Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract_plist: fix passing an alternative url #17252

Merged
merged 1 commit into from
May 8, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented May 8, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A previous change to the way the arguments are passed in to the extract_plist strategy meant that the cask object is passed in its entirety rather than passing the livecheck url - this reinstates the previous functionality.

First noticed when preparing - Homebrew/homebrew-cask#173163

CC: @samford

@bevanjkay bevanjkay marked this pull request as draft May 8, 2024 04:52
@bevanjkay bevanjkay changed the title livecheck/strategy/extract_plist: fix passing an alternative url extract_plist: fix passing an alternative url May 8, 2024
@bevanjkay bevanjkay marked this pull request as ready for review May 8, 2024 04:56
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks for catching this, @bevanjkay!

I tested this on some ExtractPlist casks that don't use a url override (i.e., url :url) and ones that do (e.g., the cloudflare-warp PR) and it works as expected. With the existing setup, the url wasn't being passed into ExtractPlist#find_versions, so the override functionality wasn't being used.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @bevanjkay!

@MikeMcQuaid MikeMcQuaid merged commit 9bf7734 into Homebrew:master May 8, 2024
25 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants