Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HOMEBREW_ARTIFACT_DOMAIN_NO_FALLBACK #17295

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

MikeMcQuaid
Copy link
Member

This fits the use-case I've heard multiple times where people want to rely exclusively on their artifact provider.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to set ruby_URL before returning in vendor-install.sh? (Sorry, reviewing from the gh CLI because the webpage refuses to load for some reason. I would have left an in-line suggestion otherwise.)

This fits the use-case I've heard multiple times where people want to
rely exclusively on their artifact provider.

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@carlocab carlocab merged commit 909e650 into master May 14, 2024
30 checks passed
@carlocab carlocab deleted the artifact_domain_no_fallback branch May 14, 2024 13:21
@MikeMcQuaid
Copy link
Member Author

Thanks @carlocab!

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants