Hide default gems warnings for Ruby 3.4. #17315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
force-pushed
the
portable-ruby-3.3.1
branch
2 times, most recently
from
a13d8d6
to
f2ebef0
Compare
Bo98
reviewed
May 16, 2024
Bo98
force-pushed
the
portable-ruby-3.3.1
branch
3 times, most recently
from
ddb0c39
to
64f60bb
Compare
MikeMcQuaid
force-pushed
the
portable-ruby-3.3.1
branch
3 times, most recently
from
9576a7b
to
727cf5e
Compare
Bo98
approved these changes
May 17, 2024
|
MikeMcQuaid
changed the title
carlocab
changed the title
carlocab
changed the title
|
Changed approach here after chatting with @Bo98 on Slack to just hide the warnings until 3.4. |
carlocab
approved these changes
May 17, 2024
These omit warnings with Ruby 3.3 and are required for Ruby 3.4. We'll fix them when we're upgrading to 3.4 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These omit warnings with Ruby 3.3 and are required for Ruby 3.4. We'll fix them when we're upgrading to 3.4 instead.