Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable HOMEBREW_AUTOREMOVE by autoremove_default" #17364

Merged
merged 1 commit into from
May 25, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

autoremove is destructive, and it can be difficult for users to
recover from it occuring when they weren't expecting it.

Fixes #17363
Fixes Homebrew/discussions#5395

This reverts commit 3d11416.
This reverts commit efb14a0.

@carlocab carlocab requested a review from a team May 25, 2024 14:08
`autoremove` is destructive, and it can be difficult for users to
recover from it occuring when they weren't expecting it.

Fixes #17363
Fixes Homebrew/discussions#5395

This reverts commit 3d11416.
This reverts commit efb14a0.
@p-linnane p-linnane mentioned this pull request May 25, 2024
3 tasks
@p-linnane p-linnane merged commit f26fa34 into master May 25, 2024
26 checks passed
@p-linnane p-linnane deleted the revert-autoremove branch May 25, 2024 17:11
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented May 26, 2024

This should not have been merged so quickly (<4 hours) without further discussion based on two reports (one of which was immediately banned) on a weekend.

We announced this as a breaking change in our release notes. Let's figure out how to improve the feature rather than yo-yoing on functionality like this.

@MikeMcQuaid
Copy link
Member

https://github.com/orgs/Homebrew/discussions/5395

It was either not manually installed or there's a bug here that needs fixed with brew autoremove, too.

#17363

In both of these cases: the solution is to run a brew install <formula>. I'm not seeing what's hard about doing so?

Note this is pretty similar behaviour to brew cleanup which will also remove cached downloads the user may soon need similarly aggressively.

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WTF!
3 participants