Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: disable OSDN urls #17366

Merged
merged 9 commits into from
May 27, 2024
Merged

Conversation

Aaron-212
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Related to Homebrew/homebrew-cask#174285
I think it's better to disable OSDN urls when auditing since their certificate is expired.

@MikeMcQuaid
Copy link
Member

Thanks @Aaron-212! Looks good once the failing CI test is 🟢.

@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @Aaron-212!

@MikeMcQuaid MikeMcQuaid merged commit 91affd1 into Homebrew:master May 27, 2024
25 checks passed
@Aaron-212 Aaron-212 deleted the disable-osdn-url branch May 27, 2024 15:32
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants