Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --scrub flag alias to cleanup command #17414

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

garritfra
Copy link
Contributor

@garritfra garritfra commented Jun 3, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
    • Not necessary IMO, already covered by command parser
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
    • This fails on my local machine, but I believe that's an issue with my xcode installation.

Fixes #17413.

Currently, brew cleanup -s triggers a cleanup with the scrub flag enabled. I would like to introduce a longer alias of this flag, --scrub, for usage in shell-scripts and alike.

@garritfra garritfra changed the title 17413: Add --scrub flag alias to cleanup command #17413: Add --scrub flag alias to cleanup command Jun 3, 2024
@garritfra garritfra changed the title #17413: Add --scrub flag alias to cleanup command Add --scrub flag alias to cleanup command Jun 3, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL this didn't have a longer version! Makes sense to me, thanks a lot for this great first PR, @garritfra!

Not at all a big deal (as many other projects do the opposite) but just for next time: no need to open an issue if you're going to open a PR right after to fix it, can just open the PR.

Thanks again, you rock! ❤️

@MikeMcQuaid MikeMcQuaid merged commit 26a87c0 into Homebrew:master Jun 3, 2024
25 checks passed
@garritfra garritfra deleted the feature/cleanup-scrub-alias branch June 3, 2024 12:59
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add brew cleanup --scrub flag variation
2 participants