bin/brew: fix tracking of original paths with brew-in-brew calls #17421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should also fix the PATH warnings here: https://github.com/Homebrew/homebrew-portable-ruby/actions/runs/9360846916 |
carlocab
approved these changes
Jun 4, 2024
ZhongRuoyu
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running something that invokes brew-within-brew, such as
brew update, the originalPATHnormally stored inHOMEBREW_PATHis lost. This is because we blockHOMEBREW_PATHfrom being set from the user environment.Instead, special case it to allow
HOMEBREW_PATHto be set ifHOMEBREW_BREW_FILEis also set which is likely to only ever happen when called within brew.This fixes system Ruby detection not working consistently and sometimes failing for
brew updatebut not other commands.