feat: use shared checks for URL cop

[SMillerDev]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This continues what I did for homepage to make sure rules are consistent between cask and formula urls.

[MikeMcQuaid]

Nice work, thanks @SMillerDev!

[SMillerDev]

Just wondering, does this one make sense for casks?

/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-cask/Casks/w/workman.rb:5:3: C: Cask/Url: Use versioned rather than branch tarballs for stable checksums.

[Bo98]

While versioned tarballs are ideal, there's version :latest/sha256 :no_check basically everywhere in casks so is usually allowed.

[SMillerDev]

After my last changes in cask there are just 3 errors remaining that I need some help with:

This gets matched as a github repo, not sure how to override that and allow this. Or how to get this to download as a tarball.

Casks/g/github.rb:9:3: C: Cask/Url: Use GitHub tarballs rather than zipballs (url is url "https://desktop.githubusercontent.com/github-desktop/releases/#{version}/GitHubDesktop-#{arch}.zip",
      verified: "desktop.githubusercontent.com/github-desktop/").
  url "https://desktop.githubusercontent.com/github-desktop/releases/#{version}/GitHubDesktop-#{arch}.zip", ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Casks/g/github@beta.rb:9:3: C: Cask/Url: Use GitHub tarballs rather than zipballs (url is url "https://desktop.githubusercontent.com/github-desktop/releases/#{version}/GitHubDesktop-#{arch}.zip",
      verified: "desktop.githubusercontent.com/github-desktop/releases/").
  url "https://desktop.githubusercontent.com/github-desktop/releases/#{version}/GitHubDesktop-#{arch}.zip", ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This repo contains zip files for distribution. Preferably I'd also override this one to allow it.

Casks/s/sol.rb:5:3: C: Cask/Url: Use GitHub tarballs rather than zipballs (url is url "https://raw.githubusercontent.com/ospfranco/sol/main/releases/#{version}.zip",
      verified: "raw.githubusercontent.com/ospfranco/sol/").
  url "https://raw.githubusercontent.com/ospfranco/sol/main/releases/#{version}.zip", ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[MikeMcQuaid]

This gets matched as a github repo, not sure how to override that and allow this. Or how to get this to download as a tarball.

https://github.com/Homebrew/brew/blob/master/Library/Homebrew/rubocops/urls.rb#L225

Add next if url.include?("desktop.githubusercontent.com/github-desktop/releases/") below here

This repo contains zip files for distribution. Preferably I'd also override this one to allow it.

https://github.com/ospfranco/sol/releases/tag/2.1.41

Looks like just default generated archives from here so this cask should be fixed to use a tarball.

[SMillerDev]

Looks like just default generated archives from here so this cask should be fixed to use a tarball.

No, it's actually https://github.com/ospfranco/sol/blob/main/releases/2.1.58.zip. The folder in the repo is called releases see ospfranco/sol#127

[MikeMcQuaid]

No, it's actually ospfranco/sol@main/releases/2.1.58.zip. The folder in the repo is called releases see ospfranco/sol#127

Oh, weird. Yeh, in that case I guess: add another exception here (probably for .match?($r{/blob/(main|master|HEAD)/releases/})

[SMillerDev]

Dropped the releases part, now we allow all zip files when they are part of the repo main|master|HEAD content. It made a bit more sense to me as a rule.

[MikeMcQuaid]

Thanks @SMillerDev, great work again!