Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract: Log formula version #17622

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

Kentzo
Copy link
Contributor

@Kentzo Kentzo commented Jul 3, 2024

When extracting based on --git-revision the version of the formula is not known to the user upfront.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When extracting based on --git-revision the version of the formula is
not known to the user upfront.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @Kentzo!

@MikeMcQuaid MikeMcQuaid merged commit 0fda9cb into Homebrew:master Jul 4, 2024
25 checks passed
@Kentzo Kentzo deleted the extract-log-version branch July 6, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants