New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: allow skipping audit methods. #2478

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 11, 2017

Add --only and --except methods which can be used to selectively enable or disable audit groups.

CC @ilovezfs is this what you had in mind? Is this useful to you?

@MikeMcQuaid MikeMcQuaid requested a review from ilovezfs Apr 15, 2017

audit: allow skipping audit methods.
Add `--only` and `--except` methods which can be used to selectively
enable or disable audit groups.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:audit-skip-methods branch from a7106e3 to 3f8722c Apr 18, 2017

@MikeMcQuaid MikeMcQuaid merged commit 55c02ae into Homebrew:master Apr 18, 2017

2 of 3 checks passed

codecov/patch 56.41% of diff hit (target 64.11%)
Details
codecov/project 64.13% (+0.01%) compared to 417f49d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:audit-skip-methods branch Apr 18, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 18, 2017

@GauthamGoli Thoughts on best way to approach this with RuboCop? Would be great to have similar functionality there.

@GauthamGoli

This comment has been minimized.

Copy link
Member

GauthamGoli commented Apr 18, 2017

@MikeMcQuaid Similar functionality is possible. RuboCop also has --only and --except options, Registry class keeps track of all cops in an array. The cops can be filtered based on --only and --except and pass them as options to check_style_json call in style.rb

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 20, 2017

@GauthamGoli A PR that passed those through would be amazing. You up for that?

@GauthamGoli

This comment has been minimized.

Copy link
Member

GauthamGoli commented Apr 21, 2017

@MikeMcQuaid Yeah, I will submit a PR.

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.