Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: allow skipping audit methods. #2478

Merged
merged 1 commit into from Apr 18, 2017

Conversation

MikeMcQuaid
Copy link
Member

Add --only and --except methods which can be used to selectively enable or disable audit groups.

CC @ilovezfs is this what you had in mind? Is this useful to you?

Add `--only` and `--except` methods which can be used to selectively
enable or disable audit groups.
@MikeMcQuaid MikeMcQuaid merged commit 55c02ae into Homebrew:master Apr 18, 2017
@MikeMcQuaid MikeMcQuaid deleted the audit-skip-methods branch April 18, 2017 08:19
@MikeMcQuaid
Copy link
Member Author

@GauthamGoli Thoughts on best way to approach this with RuboCop? Would be great to have similar functionality there.

@GauthamGoli
Copy link
Contributor

@MikeMcQuaid Similar functionality is possible. RuboCop also has --only and --except options, Registry class keeps track of all cops in an array. The cops can be filtered based on --only and --except and pass them as options to check_style_json call in style.rb

@MikeMcQuaid
Copy link
Member Author

@GauthamGoli A PR that passed those through would be amazing. You up for that?

@GauthamGoli
Copy link
Contributor

@MikeMcQuaid Yeah, I will submit a PR.

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants