audit: new formulae should not require patches. #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this also check for |
|
@ilovezfs My thought was that a |
|
That still seems like it should require someone here to take a second look since accepting new formulae with patches, even reported ones, is still sketchy. Also, the patch URL could be from a stale PR no one upstream ever acknowledged, a personal gist, an attachment to a bug report buried on Sourceforge, etc. |
We may under some circumstances accept these anyway but it's better to nudge people into the right behaviours on local `audit`s.
MikeMcQuaid
force-pushed
the
audit-new-formula-patches
branch
from
42ff4d0
to
1775c32
Compare
|
Changed to check for any patches to any spec. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may under some circumstances accept these anyway but it's better to nudge people into the right behaviours on local
audits.