New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: new formulae should not require patches. #2479

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 11, 2017

We may under some circumstances accept these anyway but it's better to nudge people into the right behaviours on local audits.

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 11, 2017

Should this also check for patch do not just __END__?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 17, 2017

@ilovezfs My thought was that a patch do is more likely to be one that's actually upstream so might actually be OK. Thoughts?

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 17, 2017

That still seems like it should require someone here to take a second look since accepting new formulae with patches, even reported ones, is still sketchy. Also, the patch URL could be from a stale PR no one upstream ever acknowledged, a personal gist, an attachment to a bug report buried on Sourceforge, etc.

audit: new formulae should not require patches.
We may under some circumstances accept these anyway but it's better to
nudge people into the right behaviours on local `audit`s.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:audit-new-formula-patches branch from 42ff4d0 to 1775c32 Apr 21, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 22, 2017

Changed to check for any patches to any spec.

@MikeMcQuaid MikeMcQuaid merged commit 96ea979 into Homebrew:master Apr 22, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 64.07%)
Details
codecov/project 63.99% (-0.08%) compared to 6e1faf5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:audit-new-formula-patches branch Apr 22, 2017

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 22, 2017

Thanks!

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.