Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: do not search taps when a qualified formula is missing #2498

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Apr 15, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

You won't find the formula in another tap when it's already qualified.

Ref: #2497 (comment).

@zmwangx zmwangx force-pushed the do-not-search-taps-for-missing-qualified-formula branch from 400d773 to 363b268 Compare April 16, 2017 00:28
@MikeMcQuaid MikeMcQuaid merged commit 226c24a into Homebrew:master Apr 17, 2017
@MikeMcQuaid
Copy link
Member

Thanks again @zmwangx!

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants