Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic: Fix suggested git remote commands #2784

Merged
merged 1 commit into from Jun 16, 2017
Merged

diagnostic: Fix suggested git remote commands #2784

merged 1 commit into from Jun 16, 2017

Conversation

bfontaine
Copy link
Contributor

@bfontaine bfontaine commented Jun 14, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

git remote add origin ... doesn’t work because there’s already a remote.

@MikeMcQuaid
Copy link
Member

Nice! Does this work both with non-existing and already existing remotes?

@bfontaine
Copy link
Contributor Author

No, but the origin.nil? case is already taken care of in both… cases.

Copy link
Contributor

@apjanke apjanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@MikeMcQuaid MikeMcQuaid merged commit 8cebfbd into Homebrew:master Jun 16, 2017
@MikeMcQuaid
Copy link
Member

Nice work @bfontaine!

@bfontaine bfontaine deleted the suspicious-git-origin branch June 16, 2017 13:35
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants