formula_installer: make unsatisifed recursive build reqs non-fatal for bottles #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Jun 23, 2017
Library/Homebrew/formula.rb
Outdated
| @@ -1548,6 +1548,14 @@ def runtime_dependencies | |||
| runtime_dependencies + runtime_requirement_deps | |||
| end | |||
|
|
|||
| def runtime_requirements | |||
There was a problem hiding this comment.
Let's just have this method in formula_installer until we need it for stuff in formula
|
One nit otherwise 👍 |
ilovezfs
force-pushed
the
runtime-requirements
branch
from
48394df
to
a44f323
Compare
so don't consider their absence fatal if we're pouring a bottle.
ilovezfs
force-pushed
the
runtime-requirements
branch
from
a44f323
to
301a6dc
Compare
|
@MikeMcQuaid PR refreshed. |
MikeMcQuaid
approved these changes
Jun 23, 2017
|
Thanks @ilovezfs 🙇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?See Homebrew/homebrew-core#14857.
A formula's build-time dependencies' runtime requirements should be
treated as build-time requirements when we're pouring a bottle.
CC @MikeMcQuaid @alyssais @JCount