New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: make unsatisifed recursive build reqs non-fatal for bottles #2815

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@ilovezfs
Copy link
Contributor

ilovezfs commented Jun 23, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

See Homebrew/homebrew-core#14857.

A formula's build-time dependencies' runtime requirements should be
treated as build-time requirements when we're pouring a bottle.

CC @MikeMcQuaid @alyssais @JCount

@@ -1548,6 +1548,14 @@ def runtime_dependencies
runtime_dependencies + runtime_requirement_deps
end

def runtime_requirements

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jun 23, 2017

Member

Let's just have this method in formula_installer until we need it for stuff in formula

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jun 23, 2017

One nit otherwise 👍

@ilovezfs ilovezfs force-pushed the ilovezfs:runtime-requirements branch from 48394df to a44f323 Jun 23, 2017

formula_installer: runtime reqs of build deps are build reqs
so don't consider their absence fatal if we're pouring a bottle.

@ilovezfs ilovezfs force-pushed the ilovezfs:runtime-requirements branch from a44f323 to 301a6dc Jun 23, 2017

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Jun 23, 2017

@MikeMcQuaid PR refreshed.

@MikeMcQuaid MikeMcQuaid merged commit f4f1f1a into Homebrew:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jun 23, 2017

Thanks @ilovezfs 🙇

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.