Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: fix SSE3 detection on Linux #2859

Merged
merged 1 commit into from
Jul 6, 2017
Merged

cpu: fix SSE3 detection on Linux #2859

merged 1 commit into from
Jul 6, 2017

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Jul 5, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

For exciting historical reasons, /proc/cpuinfo (sometimes?) lists the SSE3 instructions feature as PNI (Prescott New Instructions). My Haswell test machine (which certainly supports SSE3 instructions) doesn't have sse3 listed but does have pni listed.

c.f. https://github.com/Homebrew/homebrew-science/issues/5920

define_method(flag + "?") { flags.include? flag }
end

def sse3?
flags.include? "pni" or flags.include? "sse3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use || here.

@MikeMcQuaid MikeMcQuaid merged commit ae33f5c into Homebrew:master Jul 6, 2017
@MikeMcQuaid
Copy link
Member

Thanks for the PR @jonchang!

@jonchang jonchang deleted the fix-sse3-linux branch July 6, 2017 22:58
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants