python_requirement: add libexec/bin to PATH. #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
changed the title
ilovezfs
reviewed
Jul 14, 2017
| @@ -21,6 +21,7 @@ class PythonRequirement < Requirement | |||
| # Homebrew Python should take precedence over older Pythons in the PATH | |||
| elsif short_version != Version.create("2.7") | |||
| ENV.prepend_path "PATH", Formula["python"].opt_bin | |||
| ENV.prepend_path "PATH", Formula["python"].libexec/"bin" | |||
There was a problem hiding this comment.
should it be .opt_libexec/"bin" for the sake of consistency with the .opt_bin above it?
This avoids having to fix formulae that use `python` to make them use `python2`.
ilovezfs
approved these changes
Jul 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having to fix formulae that use
pythonto make them usepython2.For when/if Homebrew/homebrew-core#14408 gets merged.