keg: correctly cleanup old aliases. #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aliases that include `/`s end up creating directories and this is bad.
Including aliases in the tab allows e.g. `brew switch` to correctly handle switching between different keg’s aliases.
ilovezfs
reviewed
Jul 21, 2017
Library/Homebrew/keg.rb
Outdated
| FileUtils.rm_rf bad_tap_opt if bad_tap_opt.directory? | ||
|
|
||
| Pathname.glob("#{opt_record}@*").each do |a| | ||
| next if aliases.include?(a.basename) |
There was a problem hiding this comment.
may want to skip if it's an alias for a different rack
4 tasks
MikeMcQuaid
force-pushed
the
alias-fixes
branch
2 times, most recently
from
7aff27f
to
daeb6bb
Compare
ilovezfs
approved these changes
Jul 27, 2017
Cleanup old, versioned aliases and tap aliases folders when unlinking or uninstalling a keg.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup old, versioned aliases and tap aliases folders when unlinking or uninstalling a keg.
Also:
brew switchto correctly handle switching between different keg’s aliases./s end up creating directories and this is bad).Fixes #2937