Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: allow version mismatched build deps #2954

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion Library/Homebrew/formula_installer.rb
Expand Up @@ -151,6 +151,8 @@ def check_install_sanity

recursive_deps = formula.recursive_dependencies
recursive_formulae = recursive_deps.map(&:to_formula)
recursive_runtime_deps = formula.recursive_dependencies.reject(&:build?)
recursive_runtime_formulae = recursive_runtime_deps.map(&:to_formula)

recursive_dependencies = []
recursive_formulae.each do |dep|
Expand All @@ -176,7 +178,7 @@ def check_install_sanity

version_hash = {}
version_conflicts = Set.new
recursive_formulae.each do |f|
recursive_runtime_formulae.each do |f|
name = f.name
unversioned_name, = name.split("@")
version_hash[unversioned_name] ||= Set.new
Expand Down