Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor SVN and cURL download strategies." #3018

Merged
merged 1 commit into from Aug 7, 2017

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Aug 7, 2017

Reverts #2848

@JCount JCount merged commit ae1986a into master Aug 7, 2017
@JCount JCount deleted the revert-2848-refactoring branch August 7, 2017 21:33
@JCount
Copy link
Contributor

JCount commented Aug 7, 2017

@reitermarkus This had to be reverted because it was making bottle uploads to Bintray fail with:

Error: unknown keyword: extra_args
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Homebrew/utils/curl.rb:11:in `curl_args'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Taps/homebrew/homebrew-test-bot/cmd/brew-test-bot.rb:1265:in `block (2 levels) in test_ci_upload'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Taps/homebrew/homebrew-test-bot/cmd/brew-test-bot.rb:1256:in `each'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Taps/homebrew/homebrew-test-bot/cmd/brew-test-bot.rb:1256:in `block in test_ci_upload'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Taps/homebrew/homebrew-test-bot/cmd/brew-test-bot.rb:1250:in `each'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Taps/homebrew/homebrew-test-bot/cmd/brew-test-bot.rb:1250:in `test_ci_upload'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Taps/homebrew/homebrew-test-bot/cmd/brew-test-bot.rb:1429:in `test_bot'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Taps/homebrew/homebrew-test-bot/cmd/brew-test-bot.rb:1528:in `<top (required)>'
/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Homebrew/utils.rb:20:in `require?'
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Homebrew/brew.rb:101:in `<main>'
Build step 'Execute shell' marked build as failure
[WS-CLEANUP] Deleting project workspace...[WS-CLEANUP] done
Finished: FAILURE

https://jenkins.brew.sh/job/Homebrew%20Bottles/7906/console
https://jenkins.brew.sh/job/Homebrew%20Bottles/7909/console
https://jenkins.brew.sh/job/Homebrew%20Bottles/7911/console
https://jenkins.brew.sh/job/Homebrew%20Bottles/7912/console
https://jenkins.brew.sh/job/Homebrew%20Bottles/7913/console

@reitermarkus
Copy link
Member

Well, of course there had to be something that broke. 😭

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants