Tty: if NO_COLOR env var is present, disable color #3090
Conversation
|
Given there's literally no software on that list supporting this variable it's pretty far from being a standard so 👎 to merging this until this standard is much further along. |
|
Why not just change your terminal theme? You don‘t need an environment variable and it works for any software. |
|
Homebrew is also the only software on that list that has no command line flag or other option to disable colors (short of piping every command to a non-tty), so I'm starting with Homebrew. @reitermarkus Because certain programs (like vim) are configured to use colors, but with particular themes and then only sparingly. I'm not trying to remove color completely. Command-line programs outputting colored text without being told to is a relatively new phenomenon. |
It's a list of four items so I'm not surprised. Given this site/standard is something you've created yourself in the last two days and has no significant widespread adoption yet: passing on this for now, sorry. |
|
@MikeMcQuaid, even if |
|
@raindev I gave my reasons above and this PR is from almost 6 months ago when the situation was different. |
There was a problem hiding this comment.
You'll also need to add NO_COLOR to
Line 50 in b6a1302
HOMEBREW_NO_COLOR), document HOMEBREW_NO_COLOR in https://github.com/Homebrew/brew/blob/master/Library/Homebrew/manpages/brew.1.md.erb#L100 and run brew man and commit the output.
Library/Homebrew/utils/tty.rb
Outdated
| @@ -56,7 +56,7 @@ def reset_escape_sequence! | |||
| end | |||
|
|
|||
| def to_s | |||
| return "" unless $stdout.tty? | |||
| return "" unless $stdout.tty? && !ENV["NO_COLOR"] | |||
There was a problem hiding this comment.
Change this into an if (two, if necessary) and check the HOMEBREW_NO_COLOR variable instead (this will still accept NO_COLOR but be converted elsewhere).
|
I rebased to HEAD and made the requested changes, but it fails testing because of |
There was a problem hiding this comment.
fails testing because of Library/Homebrew/test/cask/dsl_spec.rb:77. I'm not sure how you want to handle that test.
Add another allow(ENV).to line below here: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/cask/dsl_spec.rb#L77
| @@ -59,7 +59,9 @@ def reset_escape_sequence! | |||
| end | |||
|
|
|||
| def to_s | |||
| return "" unless $stdout.tty? | |||
| if ENV["HOMEBREW_NO_COLOR"] || !$stdout.tty? | |||
There was a problem hiding this comment.
If this fits on one line <= 80 characters then you can do that otherwise: no worries as-is.
| expect(subject.magenta.to_s).to eq("") | ||
| expect(subject.cyan.to_s).to eq("") | ||
| expect(subject.default.to_s).to eq("") | ||
| ENV.delete "HOMEBREW_NO_COLOR" |
There was a problem hiding this comment.
Can skip this because it's done automatically
bin/brew will recognize NO_COLOR variable and copy it to HOMEBREW_NO_COLOR
|
👍 |
|
Thanks so much for your first contribution, @jcs! Without people like you submitting PRs we couldn't run this project. You rock! |
|
Thanks for reconsidering and helping this get merged Mike |
|
I'm happy to see how it turned out |
|
@jcs No problem; I saw this on Hacker News the other day and figured after that if we had more people ask about it then we could accept it now it's a bit more established. Good luck with the project! |
|
@jcs One other thought: you may want to have this set |
|
@jcs Note: this is in v1.5.5 which was just released. |
brew testswith your changes locally?If the
NO_COLORenvironment variable is set, even with a valid TTY, disable color output.