Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_remote_tap spec: fix test offline #3112

Merged
merged 1 commit into from Sep 1, 2017

Conversation

mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Sep 1, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

As pointed out by @JCount, the method being tested always returns [] immediately if HOMEBREW_NO_GITHUB_API is set even though we stub the JSON response. As a result, we get an expected [] to match ["homebrew/foo/some-formula"] failure when --online isn't passed. Unsetting HOMEBREW_NO_GITHUB_API for this one test should be safe.

Even though we stub the JSON response, the method being tested always
returns [] immediately if HOMEBREW_NO_GITHUB_API is set.
@reitermarkus reitermarkus merged commit 8187776 into Homebrew:master Sep 1, 2017
@reitermarkus
Copy link
Member

Thanks!

@mistydemeo mistydemeo deleted the search_online_failure branch September 1, 2017 16:56
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants