New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix HOMEBREW_FORMULA_PREFIX for head #3129

Merged
merged 1 commit into from Sep 10, 2017

Conversation

Projects
None yet
2 participants
@ilovezfs
Contributor

ilovezfs commented Sep 6, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

so that it includes the commit.

This fixes the issue identified in Homebrew/homebrew-core#15950 (comment) where includes and libraries installed in the formula's prefix (e.g. resources installed in libexec) cannot be used during a build because superenv is using an incorrect value for HOMEBREW_FORMULA_PREFIX that doesn't include the commit, which causes it to filter out anything in the actual prefix.

@ilovezfs ilovezfs closed this Sep 8, 2017

@ilovezfs ilovezfs reopened this Sep 8, 2017

build: fix HOMEBREW_FORMULA_PREFIX for head
so that it includes the commit.

@ilovezfs ilovezfs merged commit e108cf8 into Homebrew:master Sep 10, 2017

1 of 3 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.